proposed configuration of the fastchat worker
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 39.5k
- Forks
- 4.8k
- PR merge metrics
- No merged PRs in 30d
Description
I found that I couldn't access the endpoints in fastchat.serve.model_worker from another machine on the same network as my server because the CORS was not activated in the FastAPI application I was using. This is my modest contribution to the huge amount of work you've done.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in the fastchat.serve.model_worker module and inspect how its FastAPI application is configured. Verify the worker endpoints from another machine on the same network, then confirm that the requested CORS configuration allows the intended cross-origin access.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- fastapi, python
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100