lm-sys / lm-sys/FastChat

The effect of lora finetune with difference target_modules

Open
#1,558 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
39.5k
Forks
4.8k
PR merge metrics
No merged PRs in 30d

Description

Hello, I using default target_modules `q_proj, v_proj` the result looks good.

Will it more good if I using more target_modules trainable? such as :

```
"q_proj",
"v_proj",
"down_proj",
"gate_proj",
"up_proj",
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file, test, or entry point is named. Start by locating the LoRA fine-tuning configuration and the handling of target_modules, then compare the default q_proj/v_proj setup with the proposed down_proj, gate_proj, and up_proj targets. Done would require a reproducible evaluation showing whether the expanded target set improves results.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
ai, machine-learning
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.