Update DX Validator to validate non-dxil parts by semantic rather than memory comparison
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 29
- Forks
- 20
- Avg merge
- 5d 23h
- Merged PRs (30d)
- 5
Description
> PSV0 is done. The other parts (RDAT etc.) aren't needed until later. Discussion for refinement: repurpose this issue for the other parts and move this one out of milestone 2?
The current validator works by generating its own copy of a part and the memcmp'ing it to see if it matches. This makes it incorrectly sensitive to ordering issues, among other things.
All the validations need to be reworked to actual validate that the incoming container contains the correct data.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the DX Validator and its current generated-part and memcmp-based validation. Review the non-PSV0 parts, including RDAT, and determine how the incoming container's data should be validated semantically; done means ordering differences no longer cause false mismatches for the targeted parts.
Written by the indexing model from the issue text.
Assessment
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100