llvm / llvm/torch-mlir

Add a build/test workflow for Windows

Open
#3,985 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.9k
Forks
736
Avg merge
5d 22h
Merged PRs (30d)
15

Description

We've seen several downstream build breaks from torch-mlir due to missing test coverage. Having at least a nightly CI build using GitHub-hosted runners would provide earlier signal for build issues.

## Existing workflows

* https://github.com/llvm/torch-mlir/blob/main/.github/workflows/ci.yml only runs on Linux
* https://github.com/llvm/torch-mlir/blob/main/.github/workflows/buildRelease.yml runs on multiple platforms but was last triggered 1 year ago (https://github.com/llvm/torch-mlir/actions/workflows/buildRelease.yml)

## Expanding to new platforms

I see scripts used by ci.yml that could be forked or generalized:

* https://github.com/llvm/torch-mlir/blob/main/build_tools/ci/build_posix.sh
* https://github.com/llvm/torch-mlir/blob/main/build_tools/ci/test_posix.sh

A workflow could also be added that runs commands directly. I've been moving https://github.com/iree-org/iree (a downstream user of torch-mlir) away from such scripts, instead opting to make the build system work better out of the box using default options, with things like ccache and the choice of compiler (e.g. gcc/clang) delegated to the user's choice or a github action that configures environment variables.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reading .github/workflows/ci.yml and buildRelease.yml, then compare build_tools/ci/build_posix.sh and test_posix.sh with the project's Windows build needs. Add a GitHub-hosted Windows workflow with at least nightly build and test coverage, and verify that it provides earlier signal for Windows build issues.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, github-actions
Domain
build-system, ci-cd, testing
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.