llvm / llvm/torch-mlir

How to integrate latest torch-mlir with torch stable <= 2.4.0?

Open
#3,674 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.9k
Forks
736
Avg merge
5d 22h
Merged PRs (30d)
15

Description

Becuase of torch have changed the signature of aten.scale_dot_product_attention, the relative testcases failed when the torch is not latest nightly version. See also https://github.com/llvm/torch-mlir/pull/3627 and https://github.com/llvm/torch-mlir/pull/3666.
It's hard for me when I want to integrate latest torch-mlir with torch stable <= 2.4.0.

Is there any possible to provide compatibility? @vivekkhandelwal1 @rsuderman @stellaraccident

In short term, I think I could checkout a new branch and manually cherry pick commits which I need, until the problem have been resolved or torch==2.5.0 stable version have been released.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the relative testcases that fail around aten.scale_dot_product_attention and compare the changes in PRs 3627 and 3666. Determine the compatibility approach for torch stable versions <= 2.4.0, with the failing testcases passing against the supported stable version.

Written by the indexing model from the issue text.

Assessment

Tech stack
pytorch
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.