llvm / llvm/torch-mlir

Fx Importer and the existing dynamo support

Open
#3,033 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
1.9k
Forks
736
Avg merge
5d 22h
Merged PRs (30d)
15

Description

Can Fx Importer be used to replace dynamo support(e.g. import_fx_graph_as_func)?

If so, will Fx Importer retain the interface that accepts GraphModule as input, such as `FxImporter.import_graph_module`? I understand this to be a reasonable requirement.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the existing import_fx_graph_as_func Dynamo support and the FxImporter.import_graph_module entry point mentioned in the issue. Compare their input interfaces and determine whether Fx Importer can replace the current support while retaining GraphModule input. Done means the replacement and compatibility requirements have a clear, agreed implementation direction.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.