llvm / llvm/offload-test-suite
[Github] Enable "require resolved" for auto-merge
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18
- Forks
- 39
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 40
Description
Hello!
Would it be possible to require comments to be resolved to allow merging?
Example: https://github.com/llvm/offload-test-suite/pull/647
- Enabled auto-merge
- Steven had minor nits, but approved, so I could fix those & merge without having to wait for another cross-timezone review.
- because it had automerge, the PR for merged even with unresolved comments.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the referenced pull request, llvm/offload-test-suite#647, and the repository's current auto-merge behavior. Determine whether unresolved review comments can be required before merging; done means an auto-merge pull request is blocked while comments remain unresolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github
- Domain
- ci-cd
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100