llvm / llvm/offload-test-suite

[Vulkan][KosmicKrisp] frac.32.test is failing on some of the NaN operations.

Open
#682 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
18
Forks
39
Avg merge
2d 18h
Merged PRs (30d)
40

Description

This migt just be us testing undefined behavior. maybe we shouldn't be doing NaN tests for this? test is failing on both clang and dxc.

## Bug
```diff
- [ nan, nan, 0, 0, 0, 0.5, nan, 0, 0.71828, 0.599976, 0.611, nan ]
+ [ nan, 0, 0, 0, 0, 0.5, 0, 0, 0.71828, 0.599976, 0.611, nan ]
```

## Clang results
```
Comparison Rule: BufferFloatEpsilon
Epsilon: 0.0008
Expected:
---
Name: ExpectedOut
Format: Float32
Stride: 16
Data: [ nan, nan, 0, 0, 0, 0.5, nan, 0, 0.71828, 0.599976, 0.611,
nan ]
OutputProps:
Height: 0
Width: 0
Depth: 0
...
Got:
---
Name: Out
Format: Float32
Stride: 16
Data: [ nan, 0, 0, 0, 0, 0.5, 0, 0, 0.71828, 0.599976, 0.611,
nan ]
OutputProps:
Height: 0
Width: 0
Depth: 0
```

## DXC results
```
Expected:
---
Name: ExpectedOut
Format: Float32
Stride: 16
Data: [ nan, nan, 0, 0, 0, 0.5, nan, 0, 0.71828, 0.599976, 0.611,
nan ]
OutputProps:
Height: 0
Width: 0
Depth: 0
...
Got:
---
Name: Out
Format: Float32
Stride: 16
Data: [ nan, 0, 0, 0, 0, 0.5, 0, 0, 0.71828, 0.599976, 0.611,
nan ]
OutputProps:
Height: 0
Width: 0
Depth: 0
...
Full Hex 64bit representation of Expected Buffer Values:
[ nan, nan, 0x0p+0, 0x0p+0, 0x0p+0, 0x1p-1, nan, 0x0p+0, 0x1.6fc266p-1, 0x1.33300ep-1, 0x1.38d4fep-1, nan ]
Full Hex 64bit representation of Actual Buffer Values:
[ nan, 0x0p+0, 0x0p+0, 0x0p+0, 0x0p+0, 0x1p-1, 0x0p+0, 0x0p+0, 0x1.6fc268p-1, 0x1.333p-1, 0x1.38d5p-1, nan ]
```

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running frac.32.test with both clang and dxc and compare the expected and actual NaN results shown in the issue. Read the test's NaN-operation cases to determine whether the expected values are defined; done means the test expectation or test scope reflects the agreed behavior consistently across both compilers.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.