llvm / llvm/offload-test-suite
[SPIRV][Mac] XFAIL needed for array-dynamic-index.test
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18
- Forks
- 39
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 40
Description
Running the test `Feature/CBuffer/array-dynamic-index.test` with `check-hlsl-clang-vk` fails with:
```
[mvk-error] SPIR-V to MSL conversion error: Cannot perform any repacking for structs when it is used as a member of another struct.
```
It does not fail for DXC. And the issue seems to be because of we don't do similar struct packing as DXC. I documented the issue here: https://github.com/llvm/llvm-project/issues/177806
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running Feature/CBuffer/array-dynamic-index.test with check-hlsl-clang-vk and compare its behavior with DXC. Locate how this test records platform or compiler-specific expected failures, then mark the failing check-hlsl-clang-vk case as XFAIL; done means the test suite records the known failure without treating it as an unexpected failure.
Written by the indexing model from the issue text.
Assessment
- Domain
- compilers, testing-qa
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100