llvm / llvm/offload-test-suite

Fix Vulkan offload test suite setup to allow for wave size specification

Open
#611 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
18
Forks
39
Avg merge
2d 18h
Merged PRs (30d)
40

Description

Right now, Vulkan ignores the specified WaveSize attribute in the HLSL.
In the device creation code, there is no mention of VK_EXT_subgroup_size_control to set the wave size based on the attribute in the HLSL.
So, when Vulkan is the IR target, the device will just use the default wave size.

This issue tracks updating the test infrastructure so that the wave size specified in the HLSL is properly referenced, or an error is raised if the device doesn't support it.

---

We have [various tests](https://github.com/search?q=repo%3Allvm%2Foffload-test-suite%20WaveSize%20path%3A*.test&type=code) that rely on the WaveSize attribute to control the wave size ("subgroup size" in Vulkan terms). Vulkan/SPIRV doesn't have an equivalent to this attribute, but instead has the VK_EXT_subgroup_size_control extension that can be used for the same purpose.

For this task we should:
* find a way to expose this via the pipeline yaml
* expose supported subgroup sizes that can be used in REQUIRES clauses.
* update the existing tests to use it

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the device creation code, pipeline YAML handling, and existing tests that use the WaveSize attribute. Trace how Vulkan test requirements are currently exposed, then update the infrastructure so subgroup-size support can be referenced and unsupported sizes produce an error. The existing WaveSize tests should pass using the new REQUIRES clauses.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.