llvm / llvm/offload-test-suite
[Vulkan][Intel] `GetDimensions` test for `{RW}Buffer` fails on Vulkan
A pull request for this has already been merged.
- #1041 by @bogner — merged
- Dominant language
- C++
- Stars
- 18
- Forks
- 39
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 40
Description
The Feature/TypedBuffer/GetDimensions.test test fails on Vulkan. The test is calling GetDimensions on RWBuffer and Buffer resources.
The expected dimensions are [ 8, 5 ], DXC and Clang on Vulkan both return [ 16, 16 ].
[Exec-Tests-Windows (windows-intel, check-hlsl-vk)
GPU: Intel(R) UHD Graphics 630
Vulkan SDK: 1.4.313.1
# .---command stdout------------
# | Using Vulkan API
# | Physical device created.
# | Shader module created.
# | Copy command buffer created.
# | Memory buffers created.
# | Executed copy command buffer.
# | Execute command buffer created.
# | Descriptors: { type = 5, count = 3 }
# | Descriptor pool created.
# | Binding 3 descriptors.
# | Num Descriptor sets: 1
# | Updating Descriptor [0] { 0, 0 }
# | Updating Descriptor [1] { 0, 1 }
# | Updating Descriptor [2] { 0, 2 }
# | WriteDescriptors: 3
# | Descriptor sets created.
# | Compute pipeline created.
# | Dispatched compute shader: { 4, 1, 1 }
# | Commands created.
# | Executed compute command buffer.
# | Compute pipeline created.
# | Cleanup complete.
# `-----------------------------
# .---command stderr------------
# | Test failed: Out
# | Comparison Rule: BufferExact
# | Expected:
# | ---
# | Name: ExpectedOut
# | Format: Int32
# | Data: [ 8, 5 ]
# | OutputProps:
# | Height: 0
# | Width: 0
# | Depth: 0
# | ...
# | Got:
# | ---
# | Name: Out
# | Format: Int32
# | Data: [ 16, 16 ]
# | OutputProps:
# | Height: 0
# | Width: 0
# | Depth: 0
# | ...
# | Full Hex 64bit representation of Expected Buffer Values:
# | [ 0x8, 0x5 ]
# | Full Hex 64bit representation of Actual Buffer Values:
# | [ 0x10, 0x10 ]
# |
# `-----------------------------
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with Feature/TypedBuffer/GetDimensions.test and reproduce the Vulkan failure on the reported Intel configuration. Compare the RWBuffer and Buffer GetDimensions behavior with the expected [8, 5] and actual [16, 16] values, then verify the test passes with the correct result.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100