llvm / llvm/offload-test-suite

Add special value tests for reflect

Open
#286 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
18
Forks
39
Avg merge
2d 18h
Merged PRs (30d)
40

Description

This issue tracks adding a test for special values like NaN, inf, and denormals, for the `reflect` function.
The behavior doesn't seem to have any consistency across different hardware, so part of the issue is figuring out how to standardize this behavior across different hardware so that the same results are seen. For example, one discrepancy is what to expect in this case:
`reflect({inf, 0.0}, {0.0, 1.0})`
In some environments, the result is expected to be {inf, 0.0}
In others, the result is {nan, nan}
This is the case for 32 bit floats, I presume 16 bit floats also need to be standardized.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test path is named. Start by locating the existing reflect implementation and its tests in the offload-test-suite, then compare handling of NaN, infinity, and denormals across hardware. Done means the expected results are standardized for 32-bit and 16-bit floats, including reflect({inf, 0.0}, {0.0, 1.0}).

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing-qa
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.