llvm / llvm/offload-test-suite

[DirectX][SPRIV] Allow configuration of instanced draw parameters

Open
#1,444 2 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
18
Forks
39
Avg merge
2d 18h
Merged PRs (30d)
40

Description

Required for testing `SV_InstanceID`, `SV_StartVertexLocation`, and `SV_StartInstanceLocation`.

Current status: the test harness has all of `InstanceCount`, `FirstVertex`, and `FirstInstance` hardcoded at the
call sites that invoke `Encoder::drawInstanced`. We will need to add yaml config to pass these parameters through so they can be specified.

AC:

- [ ] Add YAML config for `InstanceCount`, `FirstVertex` and `FirstInstance` to `DispatchParametersSet`
- [ ] Pass all three values through at the three `drawInstanced` call sites
- [ ] Add an `SV_InstanceID` test to check this is assigned correctly using a readback buffer
- [ ] Add `SV_StartVertexLocation` / `SV_StartInstanceLocation` test to check these values assigned correctly using a readback buffer

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.