llvm / llvm/offload-test-suite
Need tests for arrays of vectors
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18
- Forks
- 39
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 40
Description
We encountered a WARP crash attempting to compile a shader model 6.9+ shader that uses a static const float3 data[32] = {...}; that's accessed with dynamic indices. I suspect similar issues would arise with static float3 data[32]; that has dynamic read/write access, and potentially also with function-local arrays. I believe groupshared is still required to undergo SROA to be flattened though so that's probably not going to be a problem.
But all of these should probably be explicitly tested. Filing this here rather than https://github.com/microsoft/directxshadercompiler since I suspect this is the easier place to make it happen.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or existing test is named. Start by locating the offload test suite's WARP shader tests for arrays and vectors, then add coverage for static const arrays with dynamic reads, static arrays with dynamic reads and writes, and function-local arrays. Done means the relevant shader model 6.9+ cases compile without the reported WARP crash.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers, testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100