llvm / llvm/llvm-project

[X86] Remove matchPMADDWD_2

Open
#223,368 1 comment 0 reactions 0 assignees View on GitHub
backend:X86 code-cleanup
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

After #223364 lands we shouldn't need matchPMADDWD_2 anymore - there might be some legacy CodeGen tests that need replacing with PhaseOrdering coverage to prove the patterns are addressed by the middle-end.

Contributor guide

Open the contributing guide

Research direction

Start by locating matchPMADDWD_2 and reviewing the legacy CodeGen tests that cover these patterns. After #223364 lands, inspect existing PhaseOrdering coverage and replace tests if needed. Done means the matcher is removed and PhaseOrdering coverage proves the patterns are handled by the middle-end.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.