llvm / llvm/llvm-project

Add TOSA-to-Linalg lowering pattern tests for elementwise

Open
#221,267 2 comments 0 reactions 0 assignees View on GitHub
mlir:linalg mlir:tosa
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

As detected [here](https://github.com/llvm/llvm-project/pull/220916#issuecomment-5538963626), there doesn't seem to be any elementwise tests for TOSA to Linalg, since no test had to be changed in the series.

Should be trivial to generate a repeat test for every elementwise operation from TOSA to Linalg upon a conversion pass.

Contributor guide

Open the contributing guide

Research direction

Locate the TOSA-to-Linalg conversion pass and its existing pattern tests, then inspect how elementwise operations are represented there. Add repeat coverage for each elementwise operation and run the relevant conversion tests; done means the tests exercise the lowering without requiring changes to the lowering itself.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.