llvm / llvm/llvm-project

[lld] Incorrect handling of `_LINK_`

Open Beginner friendly
#220,973 1 comment 0 reactions 0 assignees View on GitHub
lld:COFF
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

In https://github.com/llvm/llvm-project/commit/95fe8543325a, the commit message said `_LINK_` should be *appended* to the command line.

But the actual implementation *preprended* it. This is still the case for now: https://github.com/llvm/llvm-project/blob/8459fed60e363aa3a01514975038773652a5fbac/lld/COFF/DriverUtils.cpp#L929

Contributor guide

Open the contributing guide

Research direction

Start in lld/COFF/DriverUtils.cpp around line 929 and compare the implementation with commit 95fe8543325a. Verify the `_LINK_` command-line ordering and confirm that it is appended as described by the commit message.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
78/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.