llvm / llvm/llvm-project

lldb/test/Shell/Watchpoint/LocalVariableWatchpointDisabler.test is not run anywhere

Open
#218,439 2 comments 0 reactions 0 assignees View on GitHub
lldb test-suite
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

Found while investigating https://github.com/llvm/llvm-project/issues/217961.

A suspect patch for that issue is https://github.com/llvm/llvm-project/commit/0dd62ace2ee2fafcb9a08953db1b9e4e20428e28, which added this test case as Darwin only. I don't immediately see a technical reason for that, maybe just caution.

Then @jasonmolenda disabled the test on Darwin "temporarily" :) So we now have:
```
# REQUIRES: system-darwin
<...>
# UNSUPPORTED: system-darwin
```
* It would be good to get this running on Darwin again, and -
* Running anywhere, as there's a chance it would have detected https://github.com/llvm/llvm-project/issues/217961 earlier (albeit accidentally).

Contributor guide

Open the contributing guide

Research direction

Start with lldb/test/Shell/Watchpoint/LocalVariableWatchpointDisabler.test and inspect its REQUIRES and UNSUPPORTED directives, along with the linked issue 217961 and the referenced commit. Run the test through the LLDB shell test suite on Darwin and another supported system; done means it is no longer excluded and executes successfully where appropriate.

Written by the indexing model from the issue text.

Assessment

Domain
testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.