llvm / llvm/llvm-project

[CIR] Fix ptrtoaddr vs ptrtoint lowering behavior after #210729

Open
#217,026 1 comment 0 reactions 0 assignees View on GitHub
ClangIR
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

#210729 changed the behavior of how we're lowering pointer behavior in 'classic' codegen.

This change in behavior was NOT captured by CIR. #216963 updated the tests to match it.

Whatever change happens here has to analyze what happened/what logic applied to the original patch, and mirror that in CIR.

Contributor guide

Open the contributing guide

Research direction

Start by reading #210729 to understand the classic codegen lowering change, then compare it with the CIR behavior described here. Use #216963 to identify the tests that were updated, and consider the work complete when CIR mirrors the original lowering logic and those tests reflect the matching behavior.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.