llvm / llvm/llvm-project

[mlir](sparsification=parallelization-strategy=any-storage-any-loop) mlir-opt crashes at SparseTensor/Transforms/Utils/LoopEmitter.cpp:776 with assertion `numUsers == 1' failed.

Open
#216,224 1 comment 0 reactions 0 assignees View on GitHub
crash generated by fuzzer mlir:sparsetensor
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

git version: 3ae0d109f87dedd2a3f5bdf517556ba3d44283d6

MLIR Program:
```mlir
#map3 = affine_map<(d0, d1, d2, d3, d4) -> (d0 * 2 + d2, d4)>
#map4 = affine_map<(d0, d1, d2, d3, d4) -> (d4, d1 * 2 + d3)>
#map5 = affine_map<(d0, d1, d2, d3, d4) -> (d0, d1, d2, d3)>
#sparse1 = #sparse_tensor.encoding<{ map = (d0, d1) -> (d0 floordiv 2 : dense, d1 floordiv 2 : compressed, d0 mod 2 : dense, d1 mod 2 : dense) }>
#sparse2 = #sparse_tensor.encoding<{ map = (d0, d1, d2, d3) -> (d0 : dense, d1 : compressed, d2 : dense, d3 : dense) }>
module {
func.func @m4(%arg0: tensor, %arg1: tensor, %arg2: tensor) -> tensor {
%cst = arith.constant 0.000000e+00 : f32
%0 = sparse_tensor.reinterpret_map %arg0 : tensor to tensor
%1 = linalg.generic {doc = "S(i,j) += spy[S(i,j)] x SUM_k A(i,k) B(k,j)", indexing_maps = [#map3, #map4, #map5], iterator_types = ["parallel", "parallel", "parallel", "parallel", "reduction"]} ins(%arg1, %arg2 : tensor, tensor) outs(%0 : tensor) attrs = {sorted = true} {
^bb0(%in: f32, %in_0: f32, %out: f32):
%3 = sparse_tensor.unary %out : f32 to f32
present = {
^bb0(%arg3: f32):
sparse_tensor.yield %cst : f32
}
absent = {
}
%4 = sparse_tensor.reduce %out, %3, %cst : f32 {
^bb0(%arg3: f32, %arg4: f32):
%5 = arith.addf %arg3, %arg4 : f32
sparse_tensor.yield %5 : f32
}
linalg.yield %4 : f32
} -> tensor
%2 = sparse_tensor.reinterpret_map %1 : tensor to tensor
return %2 : tensor
}
}
```

Reproduce Command: `mlir-opt -sparsification=parallelization-strategy=any-storage-any-loop a.mlir`

StackTrace:
```
mlir-opt: /data2/dependency/dev/llvm-project/mlir/lib/Dialect/SparseTensor/Transforms/Utils/LoopEmitter.cpp:776: void mlir::sparse_tensor::LoopEmitter::exitForLoop(mlir::RewriterBase&, mlir::Location, llvm::MutableArrayRef): Assertion `numUsers == 1' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace and instructions to reproduce the bug.
Stack dump:
0. Program arguments: mlir-opt -sparsification=parallelization-strategy=any-storage-any-loop a.mlir
#0 0x0000565480a0849f llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x202b49f)
#1 0x0000565480a04c3c llvm::sys::RunSignalHandlers() (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x2027c3c)
#2 0x0000565480a04de3 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
#3 0x00007f63f16e1420 __restore_rt (/lib/x86_64-linux-gnu/libpthread.so.0+0x14420)
#4 0x00007f63f11cc00b raise (/lib/x86_64-linux-gnu/libc.so.6+0x4300b)
#5 0x00007f63f11ab859 abort (/lib/x86_64-linux-gnu/libc.so.6+0x22859)
#6 0x00007f63f11ab729 (/lib/x86_64-linux-gnu/libc.so.6+0x22729)
#7 0x00007f63f11bcfd6 (/lib/x86_64-linux-gnu/libc.so.6+0x33fd6)
#8 0x000056548181824a mlir::sparse_tensor::LoopEmitter::exitForLoop(mlir::RewriterBase&, mlir::Location, llvm::MutableArrayRef) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x2e3b24a)
#9 0x000056548181b078 mlir::sparse_tensor::LoopEmitter::exitCurrentLoop(mlir::RewriterBase&, mlir::Location, llvm::MutableArrayRef) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x2e3e078)
#10 0x00005654817f7918 std::optional llvm::function_ref (llvm::MutableArrayRef)>::callback_fn)>(long, llvm::MutableArrayRef) Sparsification.cpp:0:0
#11 0x000056548180cbb4 mlir::sparse_tensor::CodegenEnv::genLoopBoundary(llvm::function_ref (llvm::MutableArrayRef)>) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x2e2fbb4)
#12 0x00005654817fb7d4 endLoop(mlir::sparse_tensor::CodegenEnv&, mlir::RewriterBase&, mlir::Operation*, unsigned int, bool, bool) (.constprop.0) Sparsification.cpp:0:0
#13 0x0000565481800787 genStmt(mlir::sparse_tensor::CodegenEnv&, mlir::RewriterBase&, unsigned int, unsigned int) Sparsification.cpp:0:0
#14 0x00005654818014ac genStmt(mlir::sparse_tensor::CodegenEnv&, mlir::RewriterBase&, unsigned int, unsigned int) Sparsification.cpp:0:0
#15 0x00005654818014ac genStmt(mlir::sparse_tensor::CodegenEnv&, mlir::RewriterBase&, unsigned int, unsigned int) Sparsification.cpp:0:0
#16 0x00005654818014ac genStmt(mlir::sparse_tensor::CodegenEnv&, mlir::RewriterBase&, unsigned int, unsigned int) Sparsification.cpp:0:0
#17 0x00005654818014ac genStmt(mlir::sparse_tensor::CodegenEnv&, mlir::RewriterBase&, unsigned int, unsigned int) Sparsification.cpp:0:0
#18 0x0000565481802d50 (anonymous namespace)::GenericOpSparsifier::matchAndRewrite(mlir::linalg::GenericOp, mlir::PatternRewriter&) const Sparsification.cpp:0:0
#19 0x0000565480b1ee90 mlir::detail::OpOrInterfaceRewritePatternBase::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&) const (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x2141e90)
#20 0x0000565489b96662 mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref, llvm::function_ref, llvm::function_ref)::'lambda'()::operator()() const PatternApplicator.cpp:0:0
#21 0x0000565489b97bc8 mlir::PatternApplicator::matchAndRewrite(mlir::Operation*, mlir::PatternRewriter&, llvm::function_ref, llvm::function_ref, llvm::function_ref) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0xb1babc8)
#22 0x0000565489b61477 (anonymous namespace)::GreedyPatternRewriteDriver::processWorklist() GreedyPatternRewriteDriver.cpp:0:0
#23 0x0000565489b65736 mlir::applyPatternsGreedily(mlir::Region&, mlir::FrozenRewritePatternSet const&, mlir::GreedyRewriteConfig, bool*) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0xb188736)
#24 0x00005654817c9c92 mlir::applyPatternsGreedily(mlir::Operation*, mlir::FrozenRewritePatternSet const&, mlir::GreedyRewriteConfig, bool*) (.constprop.0) SparseTensorPasses.cpp:0:0
#25 0x00005654817d02d5 (anonymous namespace)::SparsificationPass::runOnOperation() SparseTensorPasses.cpp:0:0
#26 0x0000565489c02201 mlir::detail::OpToOpPassAdaptor::run(mlir::Pass*, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0xb225201)
#27 0x0000565489c02590 mlir::detail::OpToOpPassAdaptor::runPipeline(mlir::OpPassManager&, mlir::Operation*, mlir::AnalysisManager, bool, unsigned int, mlir::PassInstrumentor*, mlir::PassInstrumentation::PipelineParentInfo const*) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0xb225590)
#28 0x0000565489c04644 mlir::PassManager::runPasses(mlir::Operation*, mlir::AnalysisManager) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0xb227644)
#29 0x0000565489c056c1 mlir::PassManager::run(mlir::Operation*) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0xb2286c1)
#30 0x0000565480ace9bb performActions(llvm::raw_ostream&, std::shared_ptr const&, mlir::MLIRContext*, mlir::MlirOptMainConfig const&) MlirOptMain.cpp:0:0
#31 0x0000565480acf4ff processBuffer(llvm::raw_ostream&, std::unique_ptr>, llvm::MemoryBufferRef, mlir::MlirOptMainConfig const&, mlir::DialectRegistry&, mlir::SourceMgrDiagnosticVerifierHandler*, llvm::ThreadPoolInterface*) MlirOptMain.cpp:0:0
#32 0x0000565480acf72b llvm::LogicalResult llvm::function_ref>, llvm::MemoryBufferRef const&, llvm::raw_ostream&)>::callback_fn>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&)::'lambda'(std::unique_ptr>, llvm::MemoryBufferRef, llvm::raw_ostream&)>(long, std::unique_ptr>, llvm::MemoryBufferRef const&, llvm::raw_ostream&) MlirOptMain.cpp:0:0
#33 0x0000565489fd3525 mlir::splitAndProcessBuffer(std::unique_ptr>, llvm::function_ref>, llvm::MemoryBufferRef const&, llvm::raw_ostream&)>, llvm::raw_ostream&, llvm::StringRef, llvm::StringRef) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0xb5f6525)
#34 0x0000565480ac5774 mlir::MlirOptMain(llvm::raw_ostream&, std::unique_ptr>, mlir::DialectRegistry&, mlir::MlirOptMainConfig const&) (.part.0) MlirOptMain.cpp:0:0
#35 0x0000565480acfc47 mlir::MlirOptMain(int, char**, llvm::StringRef, llvm::StringRef, mlir::DialectRegistry&) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x20f2c47)
#36 0x0000565480acfe83 mlir::MlirOptMain(int, char**, llvm::StringRef, mlir::DialectRegistry&) (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x20f2e83)
#37 0x000056548094cbb7 main (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x1f6fbb7)
#38 0x00007f63f11ad083 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x24083)
#39 0x00005654809e4a6e _start (/data2/dependency/dev/llvm-project/build/bin/mlir-opt+0x2007a6e)
Aborted (core dumped)
```

Contributor guide

Open the contributing guide

Research direction

Run the supplied MLIR program with mlir-opt and the sparsification parallelization option to reproduce the assertion. Then inspect LoopEmitter::exitForLoop at LoopEmitter.cpp:776 and the surrounding Sparsification.cpp loop-generation path; done means the reproducer no longer aborts at the numUsers assertion.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.