llvm / llvm/llvm-project

Fix add_header_library to handle ARGN for use_system_file

Open
#214,579 1 comment 0 reactions 1 assignee View on GitHub

@kaladron is already working on this.

Since Aug 6, 2026.

cmake libc
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

This happens in libc/src/stdio/scanf_core/CMakeLists.txt and ${scanf_config_copts} can't be distinguished by the autoformatter to be a DEPENDS or an ARGN.

@michaelrj-google suggested having an extra parameter for this. Consult with him to figure out how best to handle this (will happen in September)

Example diff:

 add_header_library(
   scanf_config
   HDRS
     scanf_config.h
-  ${scanf_config_copts}
+    ${scanf_config_copts}
 )

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.