llvm / llvm/llvm-project

Rewrite `BreakpointResolverScripted` with proper error propagation

Open
#214,374 1 comment 0 reactions 0 assignees View on GitHub
lldb
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

The more I look at `BreakpointResolverScripted`, the more I feel like it really need an entire rewrite with proper error propagation through the entire breakpoint / target code paths but this is out of the scope of this PR. Looks fine to me with comments addressed.

https://github.com/llvm/llvm-project/pull/214308#pullrequestreview-4869842959

Contributor guide

Open the contributing guide

Research direction

Start by reading the linked pull request review, then locate BreakpointResolverScripted and trace the breakpoint and target code paths it uses. The intended done state is a rewrite with proper error propagation throughout those paths, but the issue names no files or tests and leaves the scope broad.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.