llvm / llvm/llvm-project

[libc++] Use __invoke throughout the PSTL algorithms

Open
#212,841 1 comment 1 reaction 0 assignees View on GitHub
libc++
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

Right now we call user-provided functions like `__comp(a, b)` instead of `__invoke(__comp, a, b)`, like we do for serial algorithms. This is going to become a problem with range versions of PSTL algorithms if we want to share the same underlying implementation.

Contributor guide

Open the contributing guide

Research direction

Start by locating the PSTL algorithms and compare their user-function calls with the serial algorithms that already use __invoke. Trace all affected PSTL call sites and verify that the algorithms consistently use __invoke without changing their behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.