llvm / llvm/llvm-project

[CodeGenTypes] `ConvertTypeForMem` discards attributes of matrices in an array

Open
#211,977 1 comment 0 reactions 1 assignee Claimed by @farzonl View on GitHub
clang:codegen HLSL
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

https://godbolt.org/z/ob3qMMKGa

The `ConvertTypeForMem` function does not have a case for a `ConstantArrayType` to recurse into the element type.

This was noticed in the case of a matrix as this means that we don't apply the `row_major` attribute to the underlying memory if it was present.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.