llvm / llvm/llvm-project

Cannot express depenencies from llvm-libc-macros to llvm-libc-types

Open
#209,788 2 comments 0 reactions 0 assignees View on GitHub
cmake libc
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

This is because the macros subfolder is added before "types". And our target-adding macros depend on require that the dependencies already exist.

Unsure how to resolve this. Cmake normally does not require targets to be added in dependency order, but I believe we have a lot of infrastructure built around this expectation.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how the llvm-libc-macros subfolder is added before llvm-libc-types and how the target-adding macros require existing dependencies. Read the surrounding CMake infrastructure to determine whether dependency order can be removed or must be supported; done means macros can depend on types without breaking target creation.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system, compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.