llvm / llvm/llvm-project

[DirectX] Add with overflow should emulate for everything except specifically 32-bit ops

Open
#209,255 0 comments 0 reactions 0 assignees View on GitHub
backend:DirectX
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

Our current add with overflow implementation always tries to use the 32-bit dxil ops but this only actually makes sense when doing 32 bit adds. Currently this means 16 and 64 bit operations are incorrect.

Contributor guide

Open the contributing guide

Research direction

Locate the DirectX add-with-overflow implementation and the entry point where it selects 32-bit DXIL operations. Compare the behavior for 16-, 32-, and 64-bit adds; done means non-32-bit operations emulate overflow correctly while 32-bit operations retain the DXIL path.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.