llvm / llvm/llvm-project

[clang-check][syntax] Crash in TreeBuilder::withTrailingSemicolon:Assertion `Tokens.back().kind() != tok::eof'` failed.

Open
#207,600 0 comments 0 reactions 0 assignees View on GitHub
clang-tools-extra crash generated by fuzzer
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

This is generated by a fuzzer.
```c
#define X 1
int i = __has_warning
#define JOIN(a, b) a ## b
JOIN(bar, X
```

```
clang-check \
--syntax-tree-dump \
example.c \
-- -xc -std=c11
```

stacktrace
```
clang-check: /home/ubuntu2404/llvm-project-196067/clang/lib/Tooling/Syntax/BuildTree.cpp:548: llvm::ArrayRef clang::syntax::TreeBuilder::withTrailingSemicolon(llvm::ArrayRef) const: Assertion `Tokens.back().kind() != tok::eof' failed.
#0 0x0000578c753821f1 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x96d1f1)
#1 0x0000578c7537edac llvm::sys::RunSignalHandlers() (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x969dac)
#2 0x0000578c7537ef0c SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
#3 0x0000733c97645330 (/lib/x86_64-linux-gnu/libc.so.6+0x45330)
#4 0x0000733c9769eb2c __pthread_kill_implementation ./nptl/pthread_kill.c:44:76
#5 0x0000733c9769eb2c __pthread_kill_internal ./nptl/pthread_kill.c:78:10
#6 0x0000733c9769eb2c pthread_kill ./nptl/pthread_kill.c:89:10
#7 0x0000733c9764527e raise ./signal/../sysdeps/posix/raise.c:27:6
#8 0x0000733c976288ff abort ./stdlib/abort.c:81:7
#9 0x0000733c9762881b _nl_load_domain ./intl/loadmsgcat.c:1177:9
#10 0x0000733c9763b517 (/lib/x86_64-linux-gnu/libc.so.6+0x3b517)
#11 0x0000578c757171de (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xd021de)
#12 0x0000578c7571db86 bool (anonymous namespace)::BuildTreeVisitor::processDeclaratorAndDeclaration(clang::DeclaratorDecl*) BuildTree.cpp:0:0
#13 0x0000578c75721aea clang::RecursiveASTVisitor<(anonymous namespace)::BuildTreeVisitor>::TraverseDeclContextHelper(clang::DeclContext*) BuildTree.cpp:0:0
#14 0x0000578c7573a83b clang::RecursiveASTVisitor<(anonymous namespace)::BuildTreeVisitor>::TraverseTranslationUnitDecl(clang::TranslationUnitDecl*) BuildTree.cpp:0:0
#15 0x0000578c75721439 clang::syntax::buildSyntaxTree(clang::syntax::Arena&, clang::syntax::TokenBufferTokenManager&, clang::ASTContext&) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xd0c439)
#16 0x0000578c74e154af (anonymous namespace)::DumpSyntaxTree::CreateASTConsumer(clang::CompilerInstance&, llvm::StringRef)::Consumer::HandleTranslationUnit(clang::ASTContext&) ClangCheck.cpp:0:0
#17 0x0000578c76c4bf9c clang::ParseAST(clang::Sema&, bool, bool) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x2236f9c)
#18 0x0000578c753d9271 clang::FrontendAction::Execute() (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x9c4271)
#19 0x0000578c75425308 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xa10308)
#20 0x0000578c75701cb7 clang::tooling::FrontendActionFactory::runInvocation(std::shared_ptr, clang::FileManager*, std::shared_ptr, clang::DiagnosticConsumer*) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xceccb7)
#21 0x0000578c756fbb2a clang::tooling::ToolInvocation::runInvocation(char const*, clang::driver::Compilation*, std::shared_ptr, std::shared_ptr) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xce6b2a)
#22 0x0000578c756fe1e2 clang::tooling::ToolInvocation::run() (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xce91e2)
#23 0x0000578c756ffe19 clang::tooling::ClangTool::run(clang::tooling::ToolAction*) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xceae19)
#24 0x0000578c74d9a405 main (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x385405)
#25 0x0000733c9762a1ca __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3
#26 0x0000733c9762a28b call_init ./csu/../csu/libc-start.c:128:20
#27 0x0000733c9762a28b __libc_start_main ./csu/../csu/libc-start.c:347:5
#28 0x0000578c74e14045 _start (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x3ff045)
Aborted (core dumped)
```

Contributor guide

Open the contributing guide

Research direction

Reproduce the crash with the shown example.c contents and clang-check --syntax-tree-dump, then inspect clang/lib/Tooling/Syntax/BuildTree.cpp around TreeBuilder::withTrailingSemicolon and processDeclaratorAndDeclaration. Done means the reproducer no longer triggers the assertion while syntax-tree dumping, with regression coverage for this malformed macro input.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
compilers
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.