llvm / llvm/llvm-project

[clang-check][syntax] Crash-on-valid in TreeBuilder::assignRole: assertion `“no child with the specified range”` fails

Open
#207,595 0 comments 0 reactions 0 assignees View on GitHub
clang-tools-extra crash generated by fuzzer
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

This input is generated by a fuzzer.
This seems to be a crash-on-valid?

```cpp
int (&f())[3];
```

```
clang-check --tokens-dump example.cpp -- -xc++ -std=c++23
```

Assertion:
```
`It->first == Range.begin() && "no child with the specified range"'
```

```
clang-check: /home/ubuntu2404/llvm-project-196067/clang/lib/Tooling/Syntax/BuildTree.cpp:585: void clang::syntax::TreeBuilder::Forest::assignRole(llvm::ArrayRef, clang::syntax::NodeRole): Assertion `It->first == Range.begin() && "no child with the specified range"' failed.
#0 0x00005e2d5b8bb1f1 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x96d1f1)
#1 0x00005e2d5b8b7dac llvm::sys::RunSignalHandlers() (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x969dac)
#2 0x00005e2d5b8b7f0c SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
#3 0x0000701567e45330 (/lib/x86_64-linux-gnu/libc.so.6+0x45330)
#4 0x0000701567e9eb2c __pthread_kill_implementation ./nptl/pthread_kill.c:44:76
#5 0x0000701567e9eb2c __pthread_kill_internal ./nptl/pthread_kill.c:78:10
#6 0x0000701567e9eb2c pthread_kill ./nptl/pthread_kill.c:89:10
#7 0x0000701567e4527e raise ./signal/../sysdeps/posix/raise.c:27:6
#8 0x0000701567e288ff abort ./stdlib/abort.c:81:7
#9 0x0000701567e2881b _nl_load_domain ./intl/loadmsgcat.c:1177:9
#10 0x0000701567e3b517 (/lib/x86_64-linux-gnu/libc.so.6+0x3b517)
#11 0x00005e2d5bc4fe15 clang::syntax::TreeBuilder::markChildToken(clang::SourceLocation, clang::syntax::NodeRole) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xd01e15)
#12 0x00005e2d5bc5318b (anonymous namespace)::BuildTreeVisitor::WalkUpFromFunctionTypeLoc(clang::FunctionTypeLoc) BuildTree.cpp:0:0
#13 0x00005e2d5bc5b028 clang::RecursiveASTVisitor<(anonymous namespace)::BuildTreeVisitor>::TraverseFunctionProtoTypeLoc(clang::FunctionProtoTypeLoc, bool) (.isra.0) BuildTree.cpp:0:0
#14 0x00005e2d5bc5c0f5 clang::RecursiveASTVisitor<(anonymous namespace)::BuildTreeVisitor>::TraverseTypeLoc(clang::TypeLoc, bool) (.constprop.0) BuildTree.cpp:0:0
#15 0x00005e2d5bc6d59f clang::RecursiveASTVisitor<(anonymous namespace)::BuildTreeVisitor>::TraverseFunctionHelper(clang::FunctionDecl*) BuildTree.cpp:0:0
#16 0x00005e2d5bc59ddc clang::RecursiveASTVisitor<(anonymous namespace)::BuildTreeVisitor>::TraverseDecl(clang::Decl*) BuildTree.cpp:0:0
#17 0x00005e2d5bc5aaea clang::RecursiveASTVisitor<(anonymous namespace)::BuildTreeVisitor>::TraverseDeclContextHelper(clang::DeclContext*) BuildTree.cpp:0:0
#18 0x00005e2d5bc7383b clang::RecursiveASTVisitor<(anonymous namespace)::BuildTreeVisitor>::TraverseTranslationUnitDecl(clang::TranslationUnitDecl*) BuildTree.cpp:0:0
#19 0x00005e2d5bc5a439 clang::syntax::buildSyntaxTree(clang::syntax::Arena&, clang::syntax::TokenBufferTokenManager&, clang::ASTContext&) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xd0c439)
#20 0x00005e2d5b34e4af (anonymous namespace)::DumpSyntaxTree::CreateASTConsumer(clang::CompilerInstance&, llvm::StringRef)::Consumer::HandleTranslationUnit(clang::ASTContext&) ClangCheck.cpp:0:0
#21 0x00005e2d5d184f9c clang::ParseAST(clang::Sema&, bool, bool) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x2236f9c)
#22 0x00005e2d5b912271 clang::FrontendAction::Execute() (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x9c4271)
#23 0x00005e2d5b95e308 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xa10308)
#24 0x00005e2d5bc3acb7 clang::tooling::FrontendActionFactory::runInvocation(std::shared_ptr, clang::FileManager*, std::shared_ptr, clang::DiagnosticConsumer*) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xceccb7)
#25 0x00005e2d5bc34b2a clang::tooling::ToolInvocation::runInvocation(char const*, clang::driver::Compilation*, std::shared_ptr, std::shared_ptr) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xce6b2a)
#26 0x00005e2d5bc371e2 clang::tooling::ToolInvocation::run() (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xce91e2)
#27 0x00005e2d5bc38e19 clang::tooling::ClangTool::run(clang::tooling::ToolAction*) (/home/ubuntu2404/build-196067-assert/bin/clang-check+0xceae19)
#28 0x00005e2d5b2d3405 main (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x385405)
#29 0x0000701567e2a1ca __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:74:3
#30 0x0000701567e2a28b call_init ./csu/../csu/libc-start.c:128:20
#31 0x0000701567e2a28b __libc_start_main ./csu/../csu/libc-start.c:347:5
#32 0x00005e2d5b34d045 _start (/home/ubuntu2404/build-196067-assert/bin/clang-check+0x3ff045)
Aborted (core dumped)
```

Contributor guide

Open the contributing guide

Research direction

Reproduce the assertion with clang-check --tokens-dump on the provided example.cpp command. Then inspect clang/lib/Tooling/Syntax/BuildTree.cpp, starting at Forest::assignRole and the markChildToken/FunctionTypeLoc path shown in the stack trace; done means this valid C++ input no longer aborts.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.