llvm / llvm/llvm-project

[libc++] Revisit libc++'s ABI list mechanism

Open
#207,409 0 comments 0 reactions 1 assignee Claimed by @philnik777 View on GitHub
libc++ test-suite
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

Our current ABI list mechanism is flawed: it hardcodes some symbols to ignore/not-ignore from libc++abi. It's also pretty complicated due to trying to be platform agnostic (which works so-so in the end). Instead, we could potentially simplify these tests by making them more platform specific and writing them in Lit directly. Suggestion:

```
// REQUIRES: target={{.+}}-linux-?? && libcpp-abi-whatever

RUN: nm -omg %{libcxx-dylib} | canonicalization > %t.actual.txt
RUN: split-file
RUN: diff %t.actual.txt %t.expected.txt

//--- %t.expected.txt ---
HERE LIST OF SYMBOLS / OUTPUT OF NM
////
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.