llvm / llvm/llvm-project

[BUG] ICE in clang::VarDecl::hasInitWithSideEffects() const

Open
#204,772 1 comment 0 reactions 0 assignees View on GitHub
clang:frontend crash-on-invalid generated by fuzzer
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

## Bug Report: ICE in clang::VarDecl::hasInitWithSideEffects() const

Clang crashes when compiling the following C code.

**Compiler**: clang-22 (LLVM 22.1.5, commit 5ea218a153f4d2f815b8244eab3e4b4ba5e00e6c)
**Compilation flags**: -O0
**Platform**: x86_64-linux-gnu
**Component**: frontend

This is a **frontend** crash (reproduces with `-emit-llvm -Xclang -disable-llvm-passes`).

## Reduced Test Case

> Minimized from the original fuzzer-generated input using `creduce`.

```sh
clang -O0 test.c -o /dev/null
```

```c
a b static c = __builtin_choose_expr(b, 3, 4)

```

## Crash Output

```
/root/outputs/experiments-on-metamut/surfuzz,gcc,0/OqPXIZBPgxTG_surfuzz_18.c:2:8: error: unknown type name 'bool'
2 | static bool t \= true;
| ^
/root/outputs/experiments-on-metamut/surfuzz,gcc,0/OqPXIZBPgxTG_surfuzz_18.c:2:17: error: use of undeclared identifier 'true'
2 | static bool t \= true;
| ^\~\~\~
clang-22: /root/compilers/llvm-project-release/clang/include/clang/AST/Expr.h:4872: bool clang::ChooseExpr::isConditionTrue() const: Assertion \`!isConditionDependent() && "Dependent condition isn't true or false"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.
Stack dump:
0\. Program arguments: /root/objects/llvm-project-release.obj/bin/clang-22 -cc1 -triple x86_64-unknown-linux-gnu -O0 -emit-obj -dumpdir /dev/null- -disable-free -clear-ast-before-backend -main-file-name OqPXIZBPgxTG_surfuzz_18.c -mrelocation-model pic -pic-level 2 -pic-is-pie -mframe-pointer=all -fmath-errno -ffp-contract=on -fno-rounding-math -mconstructor-aliases -funwind-tables=2 -target-cpu x86-64 -tune-cpu generic -debugger-tuning=gdb -fdebug-compilation-dir=/root/data -fcoverage-compilation-dir=/root/data -resource-dir /root/objects/llvm-project-release.obj/lib/clang/22 -internal-isystem /root/objects/llvm-project-release.obj/lib/clang/22/include -internal-isystem /usr/local/include -internal-isystem /usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include -internal-externc-isystem /usr/include/x86_64-linux-gnu -internal-externc-isystem /include -internal-externc-isystem /usr/include -ferror-limit 19 -fgnuc-version=4.2.1 -fskip-odr-check-in-gmf -faddrsig -fdwarf2-cfi-asm -o /tmp/OqPXIZBPgxTG_surfuzz_18-9c79f4.o -x c /root/outputs/experiments-on-metamut/surfuzz,gcc,0/OqPXIZBPgxTG_surfuzz_18.c
1\. /root/outputs/experiments-on-metamut/surfuzz,gcc,0/OqPXIZBPgxTG_surfuzz_18.c:3:47: current parser token ';'
#0 0x000055683357b2d2 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/root/objects/llvm-project-release.obj/bin/clang-22+0x44f62d2)
#1 0x0000556833577caf llvm::sys::RunSignalHandlers() (/root/objects/llvm-project-release.obj/bin/clang-22+0x44f2caf)
#2 0x0000556833577dfc SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
#3 0x00007f070d445520 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x42520)
#4 0x00007f070d499a7c __pthread_kill_implementation ./nptl/./nptl/pthread_kill.c:44:76
#5 0x00007f070d499a7c __pthread_kill_internal ./nptl/./nptl/pthread_kill.c:78:10
#6 0x00007f070d499a7c pthread_kill ./nptl/./nptl/pthread_kill.c:89:10
#7 0x00007f070d445476 gsignal ./signal/../sysdeps/posix/raise.c:27:6
#8 0x00007f070d42b7f3 abort ./stdlib/./stdlib/abort.c:81:7
#9 0x00007f070d42b71b _nl_load_domain ./intl/./intl/loadmsgcat.c:1177:9
#10 0x00007f070d43ce96 (/usr/lib/x86_64-linux-gnu/libc.so.6+0x39e96)
#11 0x00005568366f2e50 clang::ChooseExpr::getChosenSubExpr() const (/root/objects/llvm-project-release.obj/bin/clang-22+0x766de50)
#12 0x0000556837087a58 clang::Expr::HasSideEffects(clang::ASTContext const&, bool) const (/root/objects/llvm-project-release.obj/bin/clang-22+0x8002a58)
#13 0x0000556836f0ae03 clang::VarDecl::hasInitWithSideEffects() const (/root/objects/llvm-project-release.obj/bin/clang-22+0x7e85e03)
#14 0x0000556836d00a6c clang::ASTContext::DeclMustBeEmitted(clang::Decl const*) (/root/objects/llvm-project-release.obj/bin/clang-22+0x7c7ba6c)
#15 0x000055683614dedf clang::Sema::CheckCompleteVariableDeclaration(clang::VarDecl*) (/root/objects/llvm-project-release.obj/bin/clang-22+0x70c8edf)
#16 0x000055683617804e clang::Sema::AddInitializerToDecl(clang::Decl*, clang::Expr*, bool) (/root/objects/llvm-project-release.obj/bin/clang-22+0x70f304e)
#17 0x0000556835dd2b41 clang::Parser::ParseDeclarationAfterDeclaratorAndAttributes(clang::Declarator&, clang::Parser::ParsedTemplateInfo const&, clang::Parser::ForRangeInit*) (/root/objects/llvm-project-release.obj/bin/clang-22+0x6d4db41)
#18 0x0000556835de9ce3 clang::Parser::ParseDeclGroup(clang::ParsingDeclSpec&, clang::DeclaratorContext, clang::ParsedAttributes&, clang::Parser::ParsedTemplateInfo&, clang::SourceLocation*, clang::Parser::ForRangeInit*) (/root/objects/llvm-project-release.obj/bin/clang-22+0x6d64ce3)
#19 0x0000556835da27e1 clang::Parser::ParseDeclOrFunctionDefInternal(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec&, clang::AccessSpecifier) (/root/objects/llvm-project-release.obj/bin/clang-22+0x6d1d7e1)
#20 0x0000556835da300f clang::Parser::ParseDeclarationOrFunctionDefinition(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*, clang::AccessSpecifier) (/root/objects/llvm-project-release.obj/bin/clang-22+0x6d1e00f)
#21 0x0000556835dab896 clang::Parser::ParseExternalDeclaration(clang::ParsedAttributes&, clang::ParsedAttributes&, clang::ParsingDeclSpec*) (/root/objects/llvm-project-release.obj/bin/clang-22+0x6d26896)
#22 0x0000556835dac915 clang::Parser::ParseTopLevelDecl(clang::OpaquePtr&, clang::Sema::ModuleImportState&) (/root/objects/llvm-project-release.obj/bin/clang-22+0x6d27915)
#23 0x0000556835d8c88a clang::ParseAST(clang::Sema&, bool, bool) (/root/objects/llvm-project-release.obj/bin/clang-22+0x6d0788a)
#24 0x0000556834204987 clang::FrontendAction::Execute() (/root/objects/llvm-project-release.obj/bin/clang-22+0x517f987)
#25 0x000055683418c0e9 clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) (/root/objects/llvm-project-release.obj/bin/clang-22+0x51070e9)
#26 0x000055683430195e clang::ExecuteCompilerInvocation(clang::CompilerInstance*) (/root/objects/llvm-project-release.obj/bin/clang-22+0x527c95e)
#27 0x000055683000c657 cc1_main(llvm::ArrayRef, char const*, void*) (/root/objects/llvm-project-release.obj/bin/clang-22+0xf87657)
#28 0x0000556830001694 ExecuteCC1Tool(llvm::SmallVectorImpl&, llvm::ToolContext const&, llvm::IntrusiveRefCntPtr) driver.cpp:0:0
#29 0x0000556830006907 clang_main(int, char**, llvm::ToolContext const&) (/root/objects/llvm-project-release.obj/bin/clang-22+0xf81907)
#30 0x000055682fec40ea main (/root/objects/llvm-project-release.obj/bin/clang-22+0xe3f0ea)
#31 0x00007f070d42cd90 __libc_start_call_main ./csu/../sysdeps/nptl/libc_start_call_main.h:58:16
#32 0x00007f070d42ce40 call_init ./csu/../csu/libc-start.c:128:20
#33 0x00007f070d42ce40 __libc_start_main ./csu/../csu/libc-start.c:379:5
#34 0x0000556830000cb5 _start (/root/objects/llvm-project-release.obj/bin/clang-22+0xf7bcb5)
clang: error: unable to execute command: Aborted (core dumped)
clang: error: clang frontend command failed due to signal (use -v to see invocation)
clang version 22.1.5 (https://github.com/llvm/llvm-project.git 5ea218a153f4d2f815b8244eab3e4b4ba5e00e6c)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /root/objects/llvm-project-release.obj/bin
Build config: \+assertions
clang: note: diagnostic msg:
********************
PLEASE ATTACH THE FOLLOWING FILES TO THE BUG REPORT:
Preprocessed source(s) and associated run script(s) are located at:
clang: note: diagnostic msg: /tmp/OqPXIZBPgxTG_surfuzz_18-4b39ab.c
clang: note: diagnostic msg: /tmp/OqPXIZBPgxTG_surfuzz_18-4b39ab.sh
clang: note: diagnostic msg:
********************
EXIT_CODE: 1
```

## Preprocessed Source & Run Script

**Preprocessed source** (`/tmp/OqPXIZBPgxTG_surfuzz_18-4b39ab.c`):

```c
# 1 ""
# 1 "/root/outputs/experiments-on-metamut/surfuzz,gcc,0/OqPXIZBPgxTG_surfuzz_18.c"
extern void abort (void);
static bool t = true;
static int y = __builtin_choose_expr (t, 3, 4);
static int y = __builtin_choose_expr (2 == 4, 3, 4);
int z = __builtin_choose_expr (!__builtin_constant_p (y), 3, 4);
int
foo (int x)
{
return __builtin_choose_expr (!__builtin_constant_p (x), 3, y++);
}
int
main ()
{
if (y || z != 3 || foo (4) != 3)
abort ();
return 0;
}

```

**Run script** (`/tmp/OqPXIZBPgxTG_surfuzz_18-4b39ab.sh`):

```sh
# Crash reproducer for clang version 22.1.5 (https://github.com/llvm/llvm-project.git 5ea218a153f4d2f815b8244eab3e4b4ba5e00e6c)
# Driver args: "-O0" "/root/outputs/experiments-on-metamut/surfuzz,gcc,0/OqPXIZBPgxTG_surfuzz_18.c" "-o" "/dev/null"
# Original command: "/root/objects/llvm-project-release.obj/bin/clang-22" "-cc1" "-triple" "x86_64-unknown-linux-gnu" "-O0" "-emit-obj" "-dumpdir" "/dev/null-" "-disable-free" "-clear-ast-before-backend" "-main-file-name" "OqPXIZBPgxTG_surfuzz_18.c" "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-mframe-pointer=all" "-fmath-errno" "-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases" "-funwind-tables=2" "-target-cpu" "x86-64" "-tune-cpu" "generic" "-debugger-tuning=gdb" "-fdebug-compilation-dir=/root/data" "-fcoverage-compilation-dir=/root/data" "-resource-dir" "/root/objects/llvm-project-release.obj/lib/clang/22" "-internal-isystem" "/root/objects/llvm-project-release.obj/lib/clang/22/include" "-internal-isystem" "/usr/local/include" "-internal-isystem" "/usr/lib/gcc/x86_64-linux-gnu/12/../../../../x86_64-linux-gnu/include" "-internal-externc-isystem" "/usr/include/x86_64-linux-gnu" "-internal-externc-isystem" "/include" "-internal-externc-isystem" "/usr/include" "-ferror-limit" "19" "-fgnuc-version=4.2.1" "-fskip-odr-check-in-gmf" "-faddrsig" "-fdwarf2-cfi-asm" "-o" "/tmp/OqPXIZBPgxTG_surfuzz_18-9c79f4.o" "-x" "c" "/root/outputs/experiments-on-metamut/surfuzz,gcc,0/OqPXIZBPgxTG_surfuzz_18.c"
"/root/objects/llvm-project-release.obj/bin/clang-22" "-cc1" "-triple" "x86_64-unknown-linux-gnu" "-O0" "-emit-obj" "-dumpdir" "/dev/null-" "-disable-free" "-clear-ast-before-backend" "-main-file-name" "OqPXIZBPgxTG_surfuzz_18.c" "-mrelocation-model" "pic" "-pic-level" "2" "-pic-is-pie" "-mframe-pointer=all" "-fmath-errno" "-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases" "-funwind-tables=2" "-target-cpu" "x86-64" "-tune-cpu" "generic" "-debugger-tuning=gdb" "-fdebug-compilation-dir=/root/data" "-fcoverage-compilation-dir=/root/data" "-ferror-limit" "19" "-fgnuc-version=4.2.1" "-fskip-odr-check-in-gmf" "-faddrsig" "-fdwarf2-cfi-asm" "-x" "c" "OqPXIZBPgxTG_surfuzz_18-4b39ab.c"

```

* found via a fuzzer

[OqPXIZBPgxTG_surfuzz_18-4b39ab.c](https://github.com/user-attachments/files/29128482/OqPXIZBPgxTG_surfuzz_18-4b39ab.c)
[OqPXIZBPgxTG_surfuzz_18-4b39ab.sh](https://github.com/user-attachments/files/29128481/OqPXIZBPgxTG_surfuzz_18-4b39ab.sh)

Contributor guide

Open the contributing guide

Research direction

The crash path runs through clang::VarDecl::hasInitWithSideEffects(), Expr::HasSideEffects(), and clang::ChooseExpr::getChosenSubExpr(), with the assertion in clang/include/clang/AST/Expr.h. Start by reproducing with the attached C source and run script, then trace how the condition reaches isConditionTrue(); done means the reproducer no longer aborts.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.