llvm / llvm/llvm-project

[XCOFF] Classify XMC_RO symbols as data in getSymbolType()

Open
#194,547 0 comments 0 reactions 1 assignee Claimed by @midhuncodes7 View on GitHub
platform:aix
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

`XCOFFObjectFile::getSymbolType()` currently returns `ST_Other` for symbols with storage mapping class `XMC_RO` (read-only data in the TEXT segment). These should be classified as `ST_Data` so that symbolizers and other consumers correctly identify them as data symbols rather than falling through to the unknown case.
`XMC_RO` symbols appear in real AIX binaries and are expected to be data symbols. The `isFunction()` check already correctly excludes them from function classification (only XMC_PR and XMC_GL are functions), but the remainder of `getSymbolType()` needs to check the storage mapping class and return `ST_Data` for `XMC_RO`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.