llvm / llvm/llvm-project

code_formatter CI job double-escapes some filenames

Open
#191,156 1 comment 0 reactions 0 assignees View on GitHub
infrastructure
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

It looks like the stage `git diff -U0 --pickaxe-regex` of the code_formatter CI job is making double-escapes, which breaks it on some filenames.

For example, it escapes `libcxx/test/std/strings/basic.string/string.nonmembers/string_op!=/pointer_string.pass.cpp` as `'libcxx/test/std/strings/basic.string/string.nonmembers/string_op\!=/pointer_string.pass.cpp'` - with both quotes and backslash, like here: https://github.com/llvm/llvm-project/actions/runs/24154735536/job/70509323338?pr=191023#step:5:8

This is likely not a problem, though, if the PR was formatted correctly.

Contributor guide

Open the contributing guide

Research direction

Inspect the `code_formatter` CI job and its `git diff -U0 --pickaxe-regex` stage, then reproduce the behavior with the example filename from the issue. Done means filenames are not double-escaped while correctly formatted pull requests continue to pass the job.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, github-actions
Domain
ci-cd
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.