llvm / llvm/llvm-project

[clang] Update expected test diagnostics to include matrices as accepted types

Open
#189,147 3 comments 0 reactions 1 assignee Claimed by @farzonl View on GitHub
clang:frontend HLSL
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

After #185304, some tests expect diagnostics that say that an argument "must be a scalar or vector of floating-point types". That message is now outdated for cases where matrices are also accepted, and should instead mention "scalar, vector, or matrix of floating-point types".

This affects not only the tests added in that PR, but also existing tests that rely on the older wording. Since the change in #185304 was made in the generic `SemaChecking.cpp` path rather than HLSL-specific code, the change affects not only HLSL tests that check the old diagnostic text.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.