[X86] Investigate outstanding X86SelectionDAGInfo::verifyTargetNode warnings
Open
backend:X86
- Dominant language
- LLVM
- Stars
- 40.5k
- Forks
- 18.7k
- PR merge metrics
- PR metrics pending
Description
#168421 left a number of unaddressed issues with some target opcodes that need fixing to allow us to remove the method entirely:
https://github.com/llvm/llvm-project/pull/168421/changes#r2537873708
X86ISD::INSERTQI/EXTRQI - we don't really care about the type - we should either cast everything to MVT::v2i64 or adjust the defs in X86InstrFragmentsSIMD.td to allow any (matching) 128-bit vector type.
The others I haven't investigated much but verifyTargetNode should make it trivial to identify the incorrect node creations.
Split the work - comment on the ticket which node types you are working on.
Contributor guide
Assessment
This issue has not been assessed yet.