llvm / llvm/llvm-project

[libc++] Finish the transition to 0-1 macros

Open
#180,192 0 comments 0 reactions 1 assignee Claimed by @philnik777 View on GitHub
libc++
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

We migrated several macros from `#ifndef` to` #if MACRO` (defining the macro to `0` or `1`) in order to avoid `-Wundef` types of failures. However, we still have several macros that are using `#ifdef`. As a result, we have to check how each macro is used before using it, which is overall more confusing.

We should either finish the transition or at least clearly state which macros will stay `#ifndef` and the rationale for that.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.