llvm / llvm/llvm-project

[flang] Remove AbstractConverter usages from the Optimizer library

Open
#178,142 0 comments 0 reactions 0 assignees View on GitHub
flang
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

It seems some usages of AbstractConverter crept in in the Optimizer library in
https://github.com/llvm/llvm-project/commit/00769d69fbaa39ecdcbbaf826a35ad999bdc951e.

The Optimizer libraries are not meant to depend on data structure from Lower to avoid cycles. Beside, the AbstractConverter.h is pulling a lot of expensive headers. Propagate the needed options instead of using the converter directly.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing commit 00769d69fbaa39ecdcbbaf826a35ad999bdc951e and locating AbstractConverter usages in the Optimizer libraries. Trace which options each usage needs and identify how they can be propagated without depending on Lower data structures. Done means the Optimizer libraries no longer use AbstractConverter directly.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.