llvm / llvm/llvm-project

[mlir][linalg] Audit the usage of casts in generic bodies for specialised op conversion

Open
#175,885 2 comments 0 reactions 0 assignees View on GitHub
mlir:linalg
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

This [patch](https://github.com/llvm/llvm-project/pull/174757) fixes the issue of interpreting casts during `linalg.matmul` op variant specialisation from `linalg.generic` bodies (the original bug was filed here: https://github.com/llvm/llvm-project/issues/174517). Audit the presence of this issue in other specialisation cases and fix them in a potentially similar manner.

CC: @banach-space @adam-smnk

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the linked patch 174757 and original issue 174517, then inspect other linalg generic-body specialisation cases for the same cast interpretation problem. Done means affected cases are identified and fixed consistently with the matmul case, with validation for the affected conversions.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.