llvm / llvm/llvm-project

Move AMDGPUAttributor run earlier in pass pipeline

Open
#174,194 6 comments 0 reactions 0 assignees View on GitHub
backend:AMDGPU
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

The run of AMDGPUAttributor is run quite late. There isn't another run of instcombine or most other simplifications afterwards. It makes most sense to run with other IPO passes, where the full attributor would run (or, just as part of the attributor run).

If this were moved earlier, we could enable nofpclass propagation without depending on enabling the full attributor or attributor-light by default

Contributor guide

Open the contributing guide

Research direction

Start by tracing where AMDGPUAttributor is scheduled in the pass pipeline and compare that position with the IPO and full attributor runs. Check the ordering of instcombine and other simplification passes, then verify that moving AMDGPUAttributor earlier enables nofpclass propagation without requiring the full attributor or attributor-light by default.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.