llvm / llvm/llvm-project

[Clang] [[gnu::abi_tag]] silently accepted on Windows

Open
#173,017 0 comments 0 reactions 0 assignees View on GitHub
clang:diagnostics platform:windows
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

Currently Clang doesn't diagnose the use of `[[gnu::abi_tag]]` when targeting the Windows ABI, even though it's ignored. Instead, Clang should either issue a diagnostic that it's an unsupported attribute, or, IMO preferably, actually mangle the ABI tag into the function name. If the ABI tag isn't desired on Windows, that attribute can simply be removed after all to get the old behaviour.

Contributor guide

Open the contributing guide

Research direction

The issue names Clang's [[gnu::abi_tag]] handling and Windows ABI behavior but no files or tests. Start by searching the Clang sources and tests for gnu::abi_tag and Windows ABI mangling; done means the attribute is no longer silently ignored, with either a diagnostic or ABI-tag mangling covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.