llvm / llvm/llvm-project

[Coroutines] Should the AllocaUseVisitor call handleAlias for more instruction types?

Open
#171,306 1 comment 0 reactions 0 assignees View on GitHub
coroutines
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

In https://github.com/llvm/llvm-project/pull/156788 the AllocaUseVisitor was updated to call handleAlias for InsertElement and InsertValue instructions to fix https://github.com/llvm/llvm-project/issues/149604

It's not clear to me why the fix is just to handle those two instructions, and not others. There was some discussion about this afterwards: https://github.com/llvm/llvm-project/pull/156788#issuecomment-3284362355

This bug tracks following up on that properly.

Contributor guide

Open the contributing guide

Research direction

Start by reading AllocaUseVisitor and handleAlias, then review PR 156788 and its linked discussion to understand why InsertElement and InsertValue were added. Identify which other instruction types need equivalent handling and use the regression context from issue 149604 to define and verify the complete fix.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.