llvm / llvm/llvm-project

[clang-tidy] llvm-header-guard suggest invalid ifdef macros name

Open
#166,750 10 comments 0 reactions 1 assignee Claimed by @sathvikreddy853 View on GitHub
clang-tidy false-positive good first issue
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

When https://clang.llvm.org/extra/clang-tidy/checks/llvm/header-guard.html check sees a file with has "llvm" inside its filepath (e.g. `clang-tools-extra/clang-tidy/llvm/HeaderGuardCheck.h`), instead of making such `ifdef`:
```cpp
#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_LLVM_HEADERGUARDCHECK_H
```
The check makes:
```cpp
#ifndef LLVM_HEADERGUARDCHECK_H
```

The check removes leading part if sees "LLVM" in check-name which is incorrect.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.