llvm / llvm/llvm-project

[Attributor] Assertion `getType()->isPointerTy() && "must be pointer"' failed.

Open
#165,691 0 comments 0 reactions 0 assignees View on GitHub
crash llvm::Attributor
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

Reproducer:
https://godbolt.org/z/af544zYsx

Backtrace:
```console
opt: /root/llvm-project/llvm/lib/IR/Value.cpp:957: llvm::Align llvm::Value::getPointerAlignment(const llvm::DataLayout&) const: Assertion `getType()->isPointerTy() && "must be pointer"' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace and instructions to reproduce the bug.
Stack dump:
0. Program arguments: /opt/compiler-explorer/clang-assertions-trunk/bin/opt -o /app/output.s -S -passes=attributor
1. Running pass "attributor" on module ""
#0 0x000000000598f068 llvm::sys::PrintStackTrace(llvm::raw_ostream&, int) (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x598f068)
#1 0x000000000598bf14 SignalHandler(int, siginfo_t*, void*) Signals.cpp:0:0
#2 0x0000721c91c42520 (/lib/x86_64-linux-gnu/libc.so.6+0x42520)
#3 0x0000721c91c969fc pthread_kill (/lib/x86_64-linux-gnu/libc.so.6+0x969fc)
#4 0x0000721c91c42476 gsignal (/lib/x86_64-linux-gnu/libc.so.6+0x42476)
#5 0x0000721c91c287f3 abort (/lib/x86_64-linux-gnu/libc.so.6+0x287f3)
#6 0x0000721c91c2871b (/lib/x86_64-linux-gnu/libc.so.6+0x2871b)
#7 0x0000721c91c39e96 (/lib/x86_64-linux-gnu/libc.so.6+0x39e96)
#8 0x000000000579ac72 llvm::Value::getPointerAlignment(llvm::DataLayout const&) const (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x579ac72)
#9 0x00000000031b58c1 (anonymous namespace)::AAAlignFloating::updateImpl(llvm::Attributor&) AttributorAttributes.cpp:0:0
#10 0x000000000310c916 llvm::AbstractAttribute::update(llvm::Attributor&) (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x310c916)
#11 0x00000000031212b0 llvm::Attributor::updateAA(llvm::AbstractAttribute&) (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x31212b0)
#12 0x0000000003137863 llvm::AAAlign const* llvm::Attributor::getOrCreateAAFor(llvm::IRPosition, llvm::AbstractAttribute const*, llvm::DepClassTy, bool, bool) (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x3137863)
#13 0x000000000313b056 bool llvm::function_ref::callback_fn(long, llvm::Instruction&) Attributor.cpp:0:0
#14 0x0000000003123399 checkForAllInstructionsImpl(llvm::Attributor*, llvm::DenseMap*, llvm::DenseMapInfo, llvm::detail::DenseMapPair*>>&, llvm::function_ref, llvm::AbstractAttribute const*, llvm::AAIsDead const*, llvm::ArrayRef, bool&, bool, bool) (.constprop.0) Attributor.cpp:0:0
#15 0x0000000003138940 llvm::Attributor::identifyDefaultAbstractAttributes(llvm::Function&) (.part.0) Attributor.cpp:0:0
#16 0x0000000003139711 llvm::Attributor::identifyDefaultAbstractAttributes(llvm::Function&) (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x3139711)
#17 0x0000000003142d9b runAttributorOnFunctions(llvm::InformationCache&, llvm::SetVector, llvm::DenseSet>, 0u>&, llvm::AnalysisGetter&, llvm::CallGraphUpdater&, bool, bool) (.part.0) Attributor.cpp:0:0
#18 0x000000000314395f llvm::AttributorPass::run(llvm::Module&, llvm::AnalysisManager&) (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x314395f)
#19 0x0000000002fb687e llvm::detail::PassModel>::run(llvm::Module&, llvm::AnalysisManager&) (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x2fb687e)
#20 0x00000000057656c1 llvm::PassManager>::run(llvm::Module&, llvm::AnalysisManager&) (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x57656c1)
#21 0x0000000000985b5a llvm::runPassPipeline(llvm::StringRef, llvm::Module&, llvm::TargetMachine*, llvm::TargetLibraryInfoImpl*, llvm::ToolOutputFile*, llvm::ToolOutputFile*, llvm::ToolOutputFile*, llvm::StringRef, llvm::ArrayRef, llvm::ArrayRef>, llvm::opt_tool::OutputKind, llvm::opt_tool::VerifierKind, bool, bool, bool, bool, bool, bool, bool, bool) (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x985b5a)
#22 0x0000000000979dd1 optMain (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x979dd1)
#23 0x0000721c91c29d90 (/lib/x86_64-linux-gnu/libc.so.6+0x29d90)
#24 0x0000721c91c29e40 __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e40)
#25 0x00000000009711e5 _start (/opt/compiler-explorer/clang-assertions-trunk/bin/opt+0x9711e5)
Program terminated with signal: SIGSEGV
Compiler returned: 139
```

Contributor guide

Open the contributing guide

Research direction

Start with the linked Compiler Explorer reproducer and run opt with the attributor pass. Inspect llvm/lib/IR/Value.cpp and AttributorAttributes.cpp around getPointerAlignment and AAAlignFloating::updateImpl. Done means the reproducer no longer triggers the assertion and a regression test covers the failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.