llvm / llvm/llvm-project

AMDGPU register classes including pseudo-registers should not be allocatable

Open
#161,759 1 comment 0 reactions 0 assignees View on GitHub
backend:AMDGPU
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

Several of the SGPR register classes, particularly [SReg_32_XM0_XEXEC](https://github.com/llvm/llvm-project/blob/487cdf14f67e95f61a42389bd168b32c00995ea4/llvm/lib/Target/AMDGPU/SIRegisterInfo.td#L786) include non-allocatable source values.

These classes should be split up. The cases that include the non-allocatable source values should only be used in an isAllocatable=0 class used as the register class of source operands, and not the same register class as used for virtual registers

Contributor guide

Open the contributing guide

Research direction

Start with the SReg_32_XM0_XEXEC definition in llvm/lib/Target/AMDGPU/SIRegisterInfo.td, then inspect the other SGPR register classes that include non-allocatable source values. Trace how these classes are used for source operands and virtual registers; done means the non-allocatable cases are separated into isAllocatable=0 classes without being used for virtual registers.

Written by the indexing model from the issue text.

Assessment

Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.