llvm / llvm/llvm-project

`llvm::drop_begin` and `llvm::drop_end` are inconsistently named

Open
#160,196 0 comments 1 reaction 0 assignees View on GitHub
llvm:adt
Dominant language
LLVM
Stars
40.5k
Forks
18.7k
PR merge metrics
PR metrics pending

Description

`ADT/STLExtras.h` provides `drop_begin` and `drop_end` functions to drop the first N or last N elements from a range, respectively. These names are inconsistent with `ArrayRef` and our general STL conventions, and should instead be named `drop_front` and `drop_back`.

Contributor guide

Open the contributing guide

Research direction

Start in ADT/STLExtras.h, where llvm::drop_begin and drop_end are provided, and compare their naming with ArrayRef and the project’s general STL conventions. Search for references to both functions and update the naming consistently; done means the replacements use drop_front and drop_back without leaving the inconsistent names behind.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.