llvm / llvm/Polygeist

Unable to reconstruct for loop in lambda function

Open
#232 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
624
Forks
170
PR merge metrics
No merged PRs in 30d

Description

Hello, I noticed that the CanonicalizeFor pass is unable to reconstruct the for loop from this code:
```
struct A{
int end;
int step;
A(int end, int step) : end(end), step(step) {}
};
void use(int);

void f(int step, int end){
A a(end, step);
auto l = [a](){
for(int i = 0; i < a.end; i += a.step){
use(i);
}
};
l();
}
```
Running with ```cgeist -O3 -function='*' loop.cpp -S -o loop.mlir```, it generates this MLIR:
```
func.func @_Z1fii(%arg0: i32, %arg1: i32) attributes {llvm.linkage = #llvm.linkage} {
%c0_i32 = arith.constant 0 : i32
%c1_i64 = arith.constant 1 : i64
%0 = llvm.alloca %c1_i64 x !llvm.struct<(struct<(i32, i32)>)> : (i64) -> !llvm.ptr)>>
%1 = llvm.alloca %c1_i64 x !llvm.struct<(struct<(i32, i32)>)> : (i64) -> !llvm.ptr)>>
%2 = llvm.alloca %c1_i64 x !llvm.struct<(struct<(i32, i32)>)> : (i64) -> !llvm.ptr)>>
%3 = llvm.alloca %c1_i64 x !llvm.struct<(struct<(i32, i32)>)> : (i64) -> !llvm.ptr)>>
%4 = llvm.getelementptr %2[%c0_i32, 0] : (!llvm.ptr)>>, i32) -> !llvm.ptr>
%5 = llvm.getelementptr %4[%c0_i32, 0] : (!llvm.ptr>, i32) -> !llvm.ptr
llvm.store %arg1, %5 : !llvm.ptr
%6 = llvm.getelementptr %4[%c0_i32, 1] : (!llvm.ptr>, i32) -> !llvm.ptr
llvm.store %arg0, %6 : !llvm.ptr
%7 = llvm.load %2 : !llvm.ptr)>>
llvm.store %7, %1 : !llvm.ptr)>>
call @_ZZ1fiiEN3$_0C1EOS_(%3, %1) : (!llvm.ptr)>>, !llvm.ptr)>>) -> ()
%8 = llvm.load %3 : !llvm.ptr)>>
llvm.store %8, %0 : !llvm.ptr)>>
call @_ZZ1fiiENK3$_0clEv(%0) : (!llvm.ptr)>>) -> ()
return
}

...

func.func private @_ZZ1fiiENK3$_0clEv(%arg0: !llvm.ptr)>>) attributes {llvm.linkage = #llvm.linkage} {
%c0_i32 = arith.constant 0 : i32
%0 = llvm.getelementptr %arg0[%c0_i32, 0] : (!llvm.ptr)>>, i32) -> !llvm.ptr>
%1 = llvm.getelementptr %0[%c0_i32, 0] : (!llvm.ptr>, i32) -> !llvm.ptr
%2 = llvm.getelementptr %0[%c0_i32, 1] : (!llvm.ptr>, i32) -> !llvm.ptr
%3 = scf.while (%arg1 = %c0_i32) : (i32) -> i32 {
%4 = llvm.load %1 : !llvm.ptr
%5 = arith.cmpi slt, %arg1, %4 : i32
scf.condition(%5) %arg1 : i32
} do {
^bb0(%arg1: i32):
func.call @_Z3usei(%arg1) : (i32) -> ()
%4 = llvm.load %2 : !llvm.ptr
%5 = arith.addi %arg1, %4 : i32
scf.yield %5 : i32
}
return
}

```
The ```scf.while``` can't be raised to a ```scf.for``` in this case because the ```step``` and ```end``` are loaded from the struct pointer, and so they are not loop invariants. This could (I think) be solved by inlining the function call, but the LLVMIR MLIR dialect doesn't seem to implement the DialectInlinerInterface, and so the MLIR inliner pass bails out.
Why do Polygeist emits so many LLVMIR operations in this sample? Is there any flag that I can set to prevent that?
What are your thought about this?
Thanks,
Pietro

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the sample with the cgeist command, then start by reading the CanonicalizeFor pass and the LLVMIR MLIR dialect's inlining support. The report does not define a concrete acceptance condition; it raises questions about LLVMIR operations, loop reconstruction, and possible inlining.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.