`SubToSubView` canonicalization disabled
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 624
- Forks
- 170
- PR merge metrics
- No merged PRs in 30d
Description
Noticed that the `SubToSubView` canonicalization was disabled in a recent commit:
https://github.com/wsmoses/Polygeist/blob/main/lib/polygeist/Ops.cpp#L681
What was the reason for this? If it is interfering with the application order of the other canonicalization patterns, should it instead be moved to a separate pass?
I'm asking because for my use-case (and i presume in general) it's fairly important that the Polygeist dialect operations have been lowered to that available in upstream MLIR.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at lib/polygeist/Ops.cpp:681 and inspect the recent history that disabled SubToSubView canonicalization. Trace how the other canonicalization patterns are applied and determine whether the intended outcome is a separate pass or restored canonicalization; done means the expected Polygeist operations are lowered to available upstream MLIR operations without disrupting the existing pattern application.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- compilers
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100