llnl / llnl/zfp

generic seralization api needs to be reworked

Open
#253 1 comment 0 reactions 0 assignees View on GitHub
bug
Dominant language
C++
Stars
885
Forks
181
PR merge metrics
No merged PRs in 30d

Description

To serialize / deserialize, the docs show we need to declare a `zfp::array::header` instance, however it is now an abstract class:

```
'zfp::array::header' is an abstract class
zfp::array::header header;
```

https://zfp.readthedocs.io/en/release1.0.0/arrays.html#serialization-1

For 1.0, the ZFP api changed to use concrete dimensioned types -- and this change undermined the generic seralization cases (using base `zfp::array::header` and `zfp::array`)

Contributor guide

Open the contributing guide

Research direction

Start with the serialization example in the linked ZFP 1.0 documentation and inspect how the generic zfp::array::header and zfp::array interfaces are used. Determine the replacement generic serialization API and verify that the documented serialization and deserialization cases work without instantiating the abstract header type.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
data
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.