Adjusting test cases from mock tests to proper tests for `testZfpCuda4d<datatype>`
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 885
- Forks
- 181
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I enhanced ZFP to also support 4D arrays for CUDA and would like to open a PR soon to merge this into the main project.
However, I see when running the tests (built with `-DBUILD_TESTING_FULL=ON `) that for the 4D case, the test suite seems to run mock tests for the CUDA 4D cases and assert `0x0` due to the fact this functionality wasn't implemented previously.
I don't have much experience with GoogleTest and find the whole structure of the tests a bit confusing, can you point me to the right files/lines of code I have to adjust so the tests are testing against the actual checksum?
Thanks and best,
Jan
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Search the test sources for `testZfpCuda4d` and trace how the CUDA 4D cases are selected when `BUILD_TESTING_FULL=ON`. Read the surrounding GoogleTest cases and compare them with the non-mock 4D tests; done means the CUDA 4D cases exercise the implementation and assert its actual checksum rather than `0x0`.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100