OpenMP tests fail when ZFP_WITH_OPENMP and ZFP_WITH_HIP are both enabled
Open
Nobody has claimed this yet.
help wanted
- Dominant language
- C++
- Stars
- 885
- Forks
- 181
- PR merge metrics
- No merged PRs in 30d
Description
We are still investigating this issue, first reported on #85, which appears to be due to -fopenmp not being passed and _OPENMP not being defined when src/zfp.c is compiled. This option is passed when compiling the tests, however.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue points to src/zfp.c and the OpenMP tests; start by reproducing the failure with ZFP_WITH_OPENMP and ZFP_WITH_HIP enabled, then compare the compile options for src/zfp.c with those used for the tests. Done means the combined configuration builds with _OPENMP defined and the OpenMP tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, cpp
- Domain
- build-system, testing-qa
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100