llnl / llnl/zfp

Use FindPython when it is more supported by scikit-build

Open
#110 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
885
Forks
181
PR merge metrics
No merged PRs in 30d

Description

When trying to ensure broader compatibility with different implementations of python, I think it is likely better to use FindPython which was introduced in 3.12.

That said, it isn't fully supported by scikit-build, and as such, it is likely better to contribute efforts there in order to minimize effort duplication.

https://github.com/scikit-build/scikit-build/issues/506

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the scikit-build issue linked from this report, #506, first to determine the status of FindPython support. Then inspect zfp's build configuration to identify where Python discovery is handled. The work is complete when the supported approach is clear and the compatibility change can be verified in the project's build process.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.